Open
Conversation
dbirman
reviewed
Jan 31, 2026
Member
dbirman
left a comment
dbirman
left a comment
There was a problem hiding this comment.
Before approving I want to check if we need to remove this from the Instrument? If we don't remove it from the device properties then we run into the risk that someone puts values in both the device and in the configuration. Presumably the "rule" is that the configuration overrides the device properties but we don't have much guarantee of that. I lean toward moving things into the acquisition if they are variable like this. What do you think?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1704