feat: add serialize qc eval(s) helper method #184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added _add_qc_evaluation_url property for QC evaluation endpoint - Implemented add_qc_evaluation() method to sign and send POST requests - Added unit tests for success and failure cases - Updates import lines to follow isort standards
- Allow users to provide `qc_contents` directly when adding a QC evaluation - Include `data_asset_id` in the `qc_contents` dict for post requests - Update pydantic upper bound handling - Restore isort import recommendations
- Implement serialize_qc_evaluations to serialize QCEvaluation objects and submit them to MetadataDbClient. - Add unit tests covering: * Single QCEvaluation success * List of QCEvaluations success * Invalid data_asset_id error (simulated 404)
helen-m-lin
requested changes
Oct 20, 2025
- Renamed helper to `add_qc_evaluations_to_docdb` to clarify that it serializes and submits QC evaluations to DocDB. - Updated serialization to exclude None values for smaller payloads. - Removed redundant for-loop; MetadataDbClient.add_qc_evaluation now handles both single and multiple evaluations.
helen-m-lin
approved these changes
Oct 21, 2025
Collaborator
|
Thanks @johendrickson, looks great! @dbirman do you have any feedback for this helper before we merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #181
add_qc_evaluations_to_docdbto serialize QCEvaluation objects and submit them to MetadataDbClient.