feat: add support for adding QC evaluations via MetadataDbClient #180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added _add_qc_evaluation_url property for QC evaluation endpoint - Implemented add_qc_evaluation() method to sign and send POST requests - Added unit tests for success and failure cases - Updates import lines to follow isort standards
helen-m-lin
reviewed
Oct 8, 2025
- Allow users to provide `qc_contents` directly when adding a QC evaluation - Include `data_asset_id` in the `qc_contents` dict for post requests - Update pydantic upper bound handling - Restore isort import recommendations
5 tasks
helen-m-lin
approved these changes
Oct 9, 2025
Collaborator
helen-m-lin
left a comment
helen-m-lin
left a comment
There was a problem hiding this comment.
Minor comment about redundant code. Great job implementing these and covering edge cases. I tested out some examples locally with your scripts and they all worked! Also worked with lists of evals: qc_contents={"qc_evaluation": [qc_eval_valid, qc_eval_valid]}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #93.
_add_qc_evaluation_urlproperty for the QC evaluation endpointadd_qc_evaluation()to allow users to provideqc_contentsdirectlydata_asset_idin theqc_contentsdict for POST requests