Add metadata optional arg #400
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tings json file to be read
- pyyaml added in requirements.txt
WARNING: there is a bug on the required version of pynwb (1.0.2) that won't allow passing the field 'date_of_birth' for the Subject object. Either ther version should be updated to the most recent, or 'date_of_birth' can't be used
… file - adds ndx-labmetadata-abf extension to requirements
* change name of extension
# Conflicts: # ipfx/x_to_nwb/conversion_utils.py
* remove dandiset extension dep
Contributor
Author
|
@t-b I'm interested in your thoughts on this |
Contributor
Author
|
@t-b have you had a chance to look at this? |
Collaborator
|
@bendichter No sorry, I'm quite busy right now. |
* fixed inputs to IZeroClamp
Contributor
Author
|
@t-b We have a branch of this project where we use this feature and we have made some updates to be compatible with the latest version of PyNWB. If we create the PR, would you be available to review and integrate it? If not, I think we'll create our own fork to support these metadata features. |
Collaborator
|
@bendichter According to #492 the plan is to remove the conversion functionality from ipfx. So I don't see a good argument for merging this PR later on. @sgratiy feel free to correct me if I'm wrong. I'm happy to accept a good PR at https://github.com/byte-physics/x-to-nwb though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #399
Sorry, the commits got a little mangled. It would probably be better to squash them on merge.