pressure FFI

[timjarsky]

Resolves Get and Set of #2546

[Copilot]

Pull Request Overview

This PR implements a Foreign Function Interface (FFI) for pressure control operations, resolving get and set functionality for issue #2546. The changes refactor pressure control code by moving constants to a centralized location, promoting internal functions to public API functions, and adding new FFI functions for external pressure control.

Key changes:

• Moved pressure-related constants (ATMOSPHERIC_PRESSURE, ACCESS_*) from MIES_PressureControl.ipf to MIES_Constants.ipf for better code organization
• Changed four internal pressure control functions to public API by removing static keywords
• Added new FFI functions FFI_GetWithOptionToSetPressure() and FFI_WaitForIdle() for external pressure control operations
• Renamed P_GetPressureMode() to P_GetPressureMethod() for consistency

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File	Description
MIES_PressureControl.ipf	Removed pressure constants, promoted four functions from static to public, removed old DoPressureManual(), renamed P_GetPressureMode() to P_GetPressureMethod()
MIES_ForeignFunctionInterface.ipf	Added FFI functions for pressure control including FFI_GetWithOptionToSetPressure(), FFI_WaitForIdle(), and several test functions
MIES_DAEphys.ipf	Updated function call from P_GetPressureMode() to P_GetPressureMethod()
MIES_Constants.ipf	Added pressure constants previously in MIES_PressureControl.ipf

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[campagnola]

FFI_GetWithOptionToSetPressure accepts NaN as one of its arguments, but Igor complains that the json is invalid if I try to send a NaN.

[t-b]

FFI_GetWithOptionToSetPressure accepts NaN as one of its arguments, but Igor complains that the json is invalid if I try to send a NaN.

https://github.com/AllenInstitute/ZeroMQ-XOP/#specification explains how to write NaN.

[timjarsky]

@t-b, this branch is working well on Rig 5. I'd like to get it merged with your help/advice.

[t-b]

@timjarsky I've squashed and rebased. Will merge once CI passes.

[Copilot]

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 11 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.