delete defaultProps from imported SVGs #386
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@meganrm if you want to prioritize speed over beauty we can take this approach as a stop gap? |
interim17
force-pushed
the
fix/default-props
branch
from
e0351dc to
952c6dd
Compare
✅ Deploy Preview for cell-catalog ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
…talog into fix/default-props
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Closes #381
Solution
Got
gatsby-plugin-svgr-svgoconfigured to drop-in replacegatsby-plugin-react-svgand remove defaultProps warnings.This is a bit of a hack, just typecasting and deleting the defaultProps that seem to be added bygatsby-plugin-react-svgLikely the better long-term fix is to move away from that plugin:jacobmischka/gatsby-plugin-react-svg#59
My first few attempts to switch plugins were met with build issues. If we want a quick solution, I think this will remove the browser warnings, and we can look at switching plugins going forward?