Feat/add orchestrator unit tests #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…add-ratelimiter-tests
Contributor
|
Seems tests failed for |
Contributor
Author
Yes Ill check again |
ArjunDixit1
force-pushed
the
feat/add-orchestrator-unit-tests
branch
from
90a7f56 to
d6e3412
Compare
Contributor
Author
|
@Einswilli Its done |
Einswilli
requested changes
Oct 6, 2025
Einswilli
approved these changes
Oct 6, 2025
Contributor
Einswilli
left a comment
Einswilli
left a comment
There was a problem hiding this comment.
Thanks for your Contributions boss
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #38
This PR introduces a comprehensive suite of unit tests for the DownloadOrchestrator class, addressing the lack of test coverage for this critical component. The new tests verify its core functionality—including concurrency, error handling, and control methods—which will improve code reliability and make future changes safer to implement.
Key Changes
The new test suite (tests/core/test_download_orchestrator.py) covers the following scenarios:
Initialization: Verifies that the orchestrator is set up correctly with the specified concurrency limit.
execute_download Logic:
Tests the main success path ("happy path").
Handles failure scenarios like repository fetch errors.
Covers edge cases such as empty repositories and partial download failures.
_download_single_file Logic:
Tests the file skipping mechanism (overwrite_existing=False).
Verifies content saving and error handling during individual file downloads.
Control Methods: Ensures the cancel(), pause(), and resume() methods are functional.
How to Verify
Pull down this branch.
Install the development dependencies: pip install -e .[dev]
Run the full test suite and confirm that all tests pass:
