fix(scan): guard QR scanning on unsupported devices#48
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthrough在 Changes扫码能力检测与 UI 条件渲染
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
改了啥呀
QrShareService里用SystemCapability.Multimedia.Scan.ScanBarcode判断当前设备是否支持系统扫码 UI。为啥要改
Scan.Core和GenerateBarcode,没有ScanBarcode,这个入口在 PC 上本来就是个会摔倒的小杂鱼状态。验证
git diff --check -- entry/src/main/ets/components/CustomKeyOverlay.ets entry/src/main/ets/components/PcListTitleBar.ets entry/src/main/ets/pages/PcListPageV2.ets entry/src/main/ets/service/network/QrShareService.etsDEVECO_SDK_HOME=/Applications/DevEco-Studio.app/Contents/sdk JAVA_HOME=/Applications/DevEco-Studio.app/Contents/jbr/Contents/Home PATH=/Applications/DevEco-Studio.app/Contents/jbr/Contents/Home/bin:$PATH node hvigorw.js assembleHap --no-daemon --stacktraceentry/build/default/outputs/default/entry-default-unsigned.haphdc list targets -v只有127.0.0.1:5555 TCP Offline localhost,当前没有在线设备/模拟器。回归建议
Summary by CodeRabbit
发布说明