Conversation
feat(script): implemented deployer scrit
feat: add role-based admin controls for deployment-critical contract …
…esult returns - Change deploy_username and transfer_username signatures to Result<(), FactoryError> - Replace panic_with_error! with .ok_or(FactoryError::...)? and return Err(...) - Replace .expect() with .ok_or(FactoryError::Unauthorized)? - Update duplicate-rejection tests to use try_deploy_username and assert Err(Ok(...)) - Add deploy_username_returns_ok_on_success test (Requirements 7.3) - Add transfer_username_returns_ok_on_success test (Requirements 7.4) - Rebased on top of role-based admin controls (PR #408)
Documents known deployment blockers (B-01 through B-09), contract deployment order, post-deploy configuration steps, role/access matrix, and testnet readiness gates. Links roadmap to the new checklist. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…d claim functionality
…d-structured-events
feat: return Result from FactoryContract functions
…t-checklist docs: onchain deployment
…ct-result-apis-and-structured-events refactor: unify AuctionContract Result APIs and structured events
…its-in-EscrowContract fix: reject zero-amount deposits in EscrowContract
…ss-validation fix: return 400 on invalid Stellar address in backend routes
feat: implement add paginated auctions endpoint and user vaults retrieval API
…on-pipe Feat/backend global validation pipe
chore: add .env.example with all required backend variables
…nchain-helpers refactor: extract shared authorization and storage helpers across onc…
…ethods feat: implement Stellar contract interaction methods in StellarService
…-query-functions test: add coverage for AuctionContract singleton and query functions
…ract-structured-errors-and-events refactor: finish EscrowContract structured errors and events
…error-handling-and-structured-events refactor: normalize CoreContract error handling and structured events
…ontracts and improve error handling
…ging chore: add health check and logging (#406)
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.