[PWGDQ] fix swapped covariance values#15792
Open
harvastum wants to merge 1 commit intoAliceO2Group:masterfrom
Open
[PWGDQ] fix swapped covariance values#15792harvastum wants to merge 1 commit intoAliceO2Group:masterfrom
harvastum wants to merge 1 commit intoAliceO2Group:masterfrom
Conversation
harvastum
requested review from
alibuild,
iarsene,
lucamicheletti93 and
mcoquet642
as code owners
|
O2 linter results: ❌ 30 errors, |
github-actions
bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this fixes swapped covariances in mftMchMatcher.cxx
fwdmatchcandidates::CXYMCH, // X - Y,
fwdmatchcandidates::CPhiYMCH, // Phi - Y
fwdmatchcandidates::CPhiXMCH, // Phi - X
link
muonpropCov(1, 0), // Cov(Y, X), correct, equivalent to Cov(X, Y)
muonpropCov(2, 0), // Cov(Phi, X), should be Cov(Phi, Y) or muonpropCov(2, 1)
muonpropCov(2, 1), // Cov(Phi, Y), should be Cov(Phi, X) or muonpropCov(2, 0)
link