Skip to content

[PWGLF] Fix PresliceUnsorted + PID selection for Pions #14472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
romainschotter merged 2 commits into from
Jan 13, 2026
+62 −74
Merged

[PWGLF] Fix PresliceUnsorted + PID selection for Pions #14472

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f1f83b7
Fix presliceunsorted + pidselection for pions
scannito Jan 13, 2026
52a6c6d
Add include memory
scannito Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
136 changes: 62 additions & 74 deletions PWGLF/Tasks/Strangeness/phiStrangeCorrelation.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright 2019-2020 CERN and copyright holders of ALICE O2.

Check failure on line 1 in PWGLF/Tasks/Strangeness/phiStrangeCorrelation.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/workflow-file] 

Name of a workflow file must match the name of the main struct in it (without the PWG prefix). (Class implementation files should be in "Core" directories.)
// See https://alice-o2.web.cern.ch/copyright for details of the copyright holders.
// All rights not expressly granted are reserved.
//
Expand Down Expand Up @@ -37,6 +37,7 @@
#include "Framework/HistogramRegistry.h"
#include "Framework/O2DatabasePDGPlugin.h"
#include "Framework/runDataProcessing.h"
#include "ReconstructionDataFormats/PID.h"
#include "ReconstructionDataFormats/Track.h"
#include <Framework/StaticFor.h>

Expand All @@ -59,6 +60,7 @@
#include <array>
#include <cmath>
#include <cstdlib>
#include <memory>
#include <ranges>
#include <string>
#include <string_view>
Expand Down Expand Up @@ -132,14 +134,6 @@
}
};

/*
struct AnalysisRegion {
std::string suffix;
float minMass;
float maxMass;
};
*/

struct PhiStrangenessCorrelation {
HistogramRegistry histos{"phiStrangenessCorrelation", {}, OutputObjHandlingPolicy::AnalysisObject, true, true};

Expand All @@ -161,7 +155,6 @@
Configurable<bool> cfgPVContributor{"cfgPVContributor", true, "PV contributor track selection"};
Configurable<float> cMinKaonPtcut{"cMinKaonPtcut", 0.15f, "Track minimum pt cut"};
Configurable<float> etaMax{"etaMax", 0.8f, "eta max"};
Configurable<float> pTToUseTOF{"pTToUseTOF", 0.5f, "pT above which use TOF"};
Configurable<float> cMaxDCAzToPVcut{"cMaxDCAzToPVcut", 2.0f, "Track DCAz cut to PV Maximum"};
Configurable<std::vector<float>> cMaxDCArToPVPhi{"cMaxDCArToPVPhi", {0.004f, 0.013f, 1.0f}, "Track DCAr cut to PV for Phi"};

Expand All @@ -183,6 +176,12 @@
Configurable<float> maxChi2TPC{"maxChi2TPC", 4.0f, "max chi2 per cluster TPC"};
Configurable<int> minITSnCls{"minITSnCls", 4, "min number of ITS clusters"};
Configurable<float> maxChi2ITS{"maxChi2ITS", 36.0f, "max chi2 per cluster ITS"};

Configurable<bool> forceTOF{"forceTOF", false, "force the TOF signal for the PID"};
Configurable<float> tofPIDThreshold{"tofPIDThreshold", 0.5, "minimum pT after which TOF PID is applicable"};
Configurable<std::vector<int>> trkPIDspecies{"trkPIDspecies", std::vector<int>{o2::track::PID::Pion, o2::track::PID::Kaon, o2::track::PID::Proton}, "Trk sel: Particles species for PID, proton, pion, kaon"};
Configurable<std::vector<float>> pidTPCMax{"pidTPCMax", std::vector<float>{2., 0., 0.}, "maximum nSigma TPC"};
Configurable<std::vector<float>> pidTOFMax{"pidTOFMax", std::vector<float>{2., 0., 0.}, "maximum nSigma TOF"};
} trackConfigs;

// Configurables on phi selection
Expand Down Expand Up @@ -270,10 +269,11 @@

// Preslice for manual slicing
struct : PresliceGroup {
PresliceUnsorted<aod::McCollisionLabels> collPerMCCollision = aod::mccollisionlabel::mcCollisionId;
Preslice<SimCollisions> collPerMCCollision = aod::mccollisionlabel::mcCollisionId;
Preslice<FullMCV0s> v0PerCollision = aod::v0::collisionId;
Preslice<FullMCTracks> trackPerCollision = aod::track::collisionId;
Preslice<aod::PhimesonCandidates> phiCandPerCollision = aod::lf_selection_phi_candidate::collisionId;
Preslice<aod::V0Datas> v0PerCollision = aod::v0::collisionId;
Preslice<aod::Tracks> trackPerCollision = aod::track::collisionId;

// Preslice<aod::McParticles> mcPartPerMCCollision = aod::mcparticle::mcCollisionId;
} preslices;

Expand Down Expand Up @@ -344,9 +344,7 @@
ccdb->setLocalObjectValidityChecking();
ccdb->setFatalWhenNull(false);

// getEfficiencyMapsFromCCDB();

for (int i = 0; i < 4; ++i) {

Check failure on line 347 in PWGLF/Tasks/Strangeness/phiStrangeCorrelation.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
loadEfficiencyMapFromCCDB(static_cast<ParticleOfInterest>(i));
}
}
Expand All @@ -360,12 +358,6 @@
LOG(info) << "Efficiency map for " << particleOfInterestLabels[poi] << " loaded from CCDB";
}

/*
void getEfficiencyMapsFromCCDB()
{
}
*/

// Compute weight based on efficiencies
template <typename... BoundEffMaps>
float computeWeight(const BoundEffMaps&... boundEffMaps)
Expand Down Expand Up @@ -435,7 +427,46 @@
return true;
}

// Topological selection for pions
// PID selection for Pions
template <typename T>
bool pidSelectionPion(const T& track)
{
for (size_t speciesIndex = 0; speciesIndex < trackConfigs.trkPIDspecies->size(); ++speciesIndex) {
auto const& pid = trackConfigs.trkPIDspecies->at(speciesIndex);
auto nSigmaTPC = aod::pidutils::tpcNSigma(pid, track);

if (trackConfigs.forceTOF && !track.hasTOF()) {
return false;
}

if (speciesIndex == 0) { // First species logic
if (std::abs(nSigmaTPC) >= trackConfigs.pidTPCMax->at(speciesIndex)) {
return false; // TPC check failed
}
if (trackConfigs.forceTOF || (track.pt() > trackConfigs.tofPIDThreshold && track.hasTOF())) {
auto nSigmaTOF = aod::pidutils::tofNSigma(pid, track);
if (std::abs(nSigmaTOF) >= trackConfigs.pidTOFMax->at(speciesIndex)) {
return false; // TOF check failed
}
}
} else { // Other species logic
if (std::abs(nSigmaTPC) < trackConfigs.pidTPCMax->at(speciesIndex)) { // Check TPC nSigma first
if (track.hasTOF()) {
auto nSigmaTOF = aod::pidutils::tofNSigma(pid, track);
if (std::abs(nSigmaTOF) < trackConfigs.pidTOFMax->at(speciesIndex)) {
return false; // Reject if both TPC and TOF are within thresholds
}
} else {
return false; // Reject if only TPC is within threshold and TOF is unavailable
}
}
}
}

return true;
}

// Track selection for Pions
template <typename T>
bool selectionPion(const T& track)
{
Expand All @@ -460,70 +491,27 @@
return false;
}

if (trackConfigs.cfgIsTOFChecked && track.pt() >= trackConfigs.pTToUseTOF && !track.hasTOF())
if (trackConfigs.cfgIsTOFChecked && track.pt() >= trackConfigs.tofPIDThreshold && !track.hasTOF())
return false;

if (analysisMode == 1 && !pidSelectionPion(track))
return false;

/*
if (analysisMode == 1) {
if (track.pt() < trackConfigs.pTToUseTOF && std::abs(track.tpcNSigmaPi()) >= trackConfigs.nSigmaCutTPCPrimPion)
if (track.pt() < trackConfigs.tofPIDThreshold && std::abs(track.tpcNSigmaPi()) >= trackConfigs.nSigmaCutTPCPrimPion)
return false;
if (trackConfigs.cfgIsTOFChecked && track.pt() >= trackConfigs.pTToUseTOF && (std::pow(track.tofNSigmaPi(), 2) + std::pow(track.tpcNSigmaPi(), 2)) >= std::pow(trackConfigs.nSigmaCutCombinedPi, 2))
if (trackConfigs.cfgIsTOFChecked && track.pt() >= trackConfigs.tofPIDThreshold && (std::pow(track.tofNSigmaPi(), 2) + std::pow(track.tpcNSigmaPi(), 2)) >= std::pow(trackConfigs.nSigmaCutCombinedPi, 2))
return false;
}
*/

if (std::abs(track.rapidity(massPi)) > yConfigs.cfgYAcceptance)
return false;

return true;
}

/*
void processPhiK0SPionDeltayDeltaphiData2D(SelCollisions::iterator const& collision, aod::PhimesonCandidates const& phiCandidates, FullTracks const& fullTracks, FullV0s const& V0s, V0DauTracks const&)
{
float multiplicity = collision.centFT0M();

std::vector<AnalysisRegion> analysisRegions = {
{"Signal", phiConfigs.rangeMPhiSignal.first, phiConfigs.rangeMPhiSignal.second},
{"Sideband", phiConfigs.rangeMPhiSideband.first, phiConfigs.rangeMPhiSideband.second}};

// Loop over all positive tracks
for (const auto& phiCand : phiCandidates) {
float weightPhi = computeWeight(BoundEfficiencyMap(effMapPhi, multiplicity, phiCand.pt(), phiCand.y()));

histos.fill(HIST("phi/h3PhiData"), multiplicity, phiCand.pt(), phiCand.m(), weightPhi);

for (const auto& region : analysisRegions) {
if (!phiCand.inMassRegion(region.minMass, region.maxMass))
continue;

// V0 already reconstructed by the builder
for (const auto& v0 : V0s) {
// Cut on V0 dynamic columns
if (!selectionV0<false>(v0, collision))
continue;

float weightPhiK0S = computeWeight(BoundEfficiencyMap(effMapPhi, multiplicity, phiCand.pt(), phiCand.y()),
BoundEfficiencyMap(effMapK0S, multiplicity, v0.pt(), v0.yK0Short()));

histos.fill(HIST("phiK0S/h5PhiK0SData2PartCorr"), multiplicity, phiCand.pt(), v0.pt(), phiCand.y() - v0.yK0Short(), phiCand.phi() - v0.phi(), weightPhiK0S);
}

// Loop over all primary pion candidates
for (const auto& track : fullTracks) {
if (!selectionPion(track))
continue;

float weightPhiPion = computeWeight(BoundEfficiencyMap(effMapPhi, multiplicity, phiCand.pt(), phiCand.y()),
track.pt() < trackConfigs.pTToUseTOF ? BoundEfficiencyMap(effMapPionTPC, multiplicity, track.pt(), track.rapidity(massPi)) : BoundEfficiencyMap(effMapPionTPCTOF, multiplicity, track.pt(), track.rapidity(massPi)));

histos.fill(HIST("phiPi/h5PhiPiData2PartCorr"), multiplicity, phiCand.pt(), track.pt(), phiCand.y() - track.rapidity(massPi), phiCand.phi() - track.phi(), weightPhiPion);
}
}
}
}

PROCESS_SWITCH(PhiStrangenessCorrelation, processPhiK0SPionDeltayDeltaphiData2D, "Process function for Phi-K0S and Phi-Pion Deltay and Deltaphi 2D Correlations in Data", true);
*/

void processPhiK0SPionDeltayDeltaphiData2D(SelCollisions::iterator const& collision, aod::PhimesonCandidates const& phiCandidates, FullTracks const& fullTracks, FullV0s const& V0s, V0DauTracks const&)
{
float multiplicity = collision.centFT0M();
Expand Down Expand Up @@ -565,12 +553,12 @@
if (!selectionPion(track))
continue;

auto Pion = track.pt() < trackConfigs.pTToUseTOF ? PionTPC : PionTPCTOF;
auto Pion = track.pt() < trackConfigs.tofPIDThreshold ? PionTPC : PionTPCTOF;

float weightPhiPion = computeWeight(BoundEfficiencyMap(effMaps[Phi], multiplicity, phiCand.pt(), phiCand.y()),
BoundEfficiencyMap(effMaps[Pion], multiplicity, track.pt(), track.rapidity(massPi)));

/*auto effMapPion = track.pt() < trackConfigs.pTToUseTOF ? effMapPionTPC : effMapPionTPCTOF;
/*auto effMapPion = track.pt() < trackConfigs.tofPIDThreshold ? effMapPionTPC : effMapPionTPCTOF;

float weightPhiPion = computeWeight(BoundEfficiencyMap(effMapPhi, multiplicity, phiCand.pt(), phiCand.y()),
BoundEfficiencyMap(effMapPion, multiplicity, track.pt(), track.rapidity(massPi)));*/
Expand Down
Loading