[PWGCF] DptDpt - Moving .cxx included file to .h

[victor-gonzalez]

No description provided.

[github-actions]

O2 linter results: ❌ 62 errors, ⚠️ 73 warnings, 🔕 0 disabled

[victor-gonzalez]

@vkucera Just wanted to move the included .cxx file to .h as you suggested
linter errors and warning will be fixed in subsequent steps
MegaLinter error is harder to fix because the file is included twice, once per task, in one of the source files so the #ifndef header guard will prevent proper compilation

[vkucera]

Hi @victor-gonzalez , thanks for the fix. Concerning the header guards, the whole idea of including a file in the middle of a source file to paste some code verbatim is wrong. If one needs to paste code, it should be done with a preprocessor macro which can be defined in the header which will be only included once at the top of the source. But even that is a bad idea and should be done better with properly defined C++ objects.

[victor-gonzalez]

Hi @victor-gonzalez , thanks for the fix. Concerning the header guards, the whole idea of including a file in the middle of a source file to paste some code verbatim is wrong. If one needs to paste code, it should be done with a preprocessor macro which can be defined in the header which will be only included once at the top of the source. But even that is a bad idea and should be done better with properly defined C++ objects.

I agree but that will take some time. For the time being, I will merge this one and address the full issue in the coming weeks.
Thanks!

[vkucera]

Hi @victor-gonzalez , thanks for the fix. Concerning the header guards, the whole idea of including a file in the middle of a source file to paste some code verbatim is wrong. If one needs to paste code, it should be done with a preprocessor macro which can be defined in the header which will be only included once at the top of the source. But even that is a bad idea and should be done better with properly defined C++ objects.

I agree but that will take some time. For the time being, I will merge this one and address the full issue in the coming weeks. Thanks!

Very good, thanks @victor-gonzalez !

[alibuild]

Auto-approving on behalf of @victor-gonzalez.