[PWGJE] jetSpectraCharged: standardise event sel, and other small changes #13674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aimeric-landou
commented
Nov 4, 2025
aimeric-landou
commented
- clean collision histograms
- standardise event selection
- fix inconsistencies between similar process functions
- fix incorrect pthatmax cut in some process functions,
- pthat plots now filled once per coll rather than once per jet
- added weighted version of areasub mcd/mcp
…election, fix inconsistencies between similar process functions, fix faulty pthatmax cut in some process functions, pthat plots now filled once per coll rather than once per jet, added weighted version of areasub mcd/mcp
aimeric-landou
requested review from
alibuild,
fjonasALICE,
maoyx,
mfasDa,
mhemmer-cern and
nzardosh
as code owners
|
O2 linter results: ❌ 0 errors, |
nzardosh
previously approved these changes
Nov 4, 2025
nzardosh
reviewed
Nov 4, 2025
PWGJE/Tasks/jetSpectraCharged.cxx
Outdated
| bool checkConstituentPt = true; | ||
| bool checkConstituentMinPt = (leadingConstituentPtMin > -98.0); | ||
| bool checkConstituentMaxPt = (leadingConstituentPtMax < 9998.0); | ||
| bool checkConstituentMinPt = (leadingConstituentPtMin > -configSwitchLow); |
Collaborator
There was a problem hiding this comment.
why is this negative? the configSwitchLow is already negative isn't it?
Contributor
Author
There was a problem hiding this comment.
you're right, the - needs to go
nzardosh
approved these changes
Nov 4, 2025
lmattei01
pushed a commit
to lmattei01/O2Physics
that referenced
this pull request
Dec 5, 2025
MattOckleton
pushed a commit
to MattOckleton/O2Physics
that referenced
this pull request
Jan 14, 2026
mapalhares
pushed a commit
to mapalhares/O2Physics
that referenced
this pull request
Jan 20, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.