Skip to content

Conversation

@AliAkrem
Copy link
Owner

@AliAkrem AliAkrem commented May 21, 2025

I've implemented a native Android splash screen for you.

Description

Here's what I did:

  • Added splash_background.xml drawable for a simple white background.
  • Defined SplashTheme in styles.xml to use this drawable.
  • Updated AndroidManifest.xml to apply SplashTheme to MainActivity and configured the io.flutter.embedding.android.SplashScreenDrawable metadata.
  • MainActivity.kt was not modified as modern Flutter versions handle the transition with the metadata configuration.

Types of changes

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Others (any other types not listed above)

Checklist

Summary by CodeRabbit

  • New Features
    • Introduced a new splash screen theme for the Android app, providing an updated visual experience during app launch.
    • Added a custom splash screen background with a clean, white appearance.

I've implemented a native Android splash screen for you.

Here's what I did:
- Added `splash_background.xml` drawable for a simple white background.
- Defined `SplashTheme` in `styles.xml` to use this drawable.
- Updated `AndroidManifest.xml` to apply `SplashTheme` to `MainActivity` and configured the `io.flutter.embedding.android.SplashScreenDrawable` metadata.
- `MainActivity.kt` was not modified as modern Flutter versions handle the transition with the metadata configuration.

I couldn't test this in my automated environment because the necessary Flutter/Android build tools were missing. I recommend you manually verify this in a development environment.
@vercel
Copy link

vercel bot commented May 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
progres ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2025 0:05am

@coderabbitai
Copy link
Contributor

coderabbitai bot commented May 21, 2025

Walkthrough

The changes introduce a new splash screen for the Android application. A splash background drawable and a dedicated "SplashTheme" are added. The AndroidManifest is updated to apply the new theme to MainActivity and to reference the splash screen drawable via metadata, enabling a custom splash experience during app launch.

Changes

File(s) Change Summary
android/app/src/main/AndroidManifest.xml Changed MainActivity's theme to @style/SplashTheme and added <meta-data> for splash drawable.
android/app/src/main/res/drawable/splash_background.xml Added a new drawable resource defining a solid white rectangular splash background.
android/app/src/main/res/values/styles.xml Added a new style SplashTheme inheriting from AppCompat and setting the window background.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Android OS
    participant MainActivity
    participant Flutter Engine

    User->>Android OS: Launches App
    Android OS->>MainActivity: Starts MainActivity with SplashTheme
    MainActivity->>Android OS: Loads splash_background drawable
    MainActivity->>Flutter Engine: Initializes Flutter
    Flutter Engine->>MainActivity: Signals Flutter UI ready
    MainActivity->>Android OS: Switches to normal theme/UI
Loading

Poem

A hop, a skip, a splash of white,
The app now greets with pure delight.
New theme and drawable, shining bright,
As MainActivity takes its flight.
With every launch, a fresh new scene—
The splash arrives, crisp and clean!
🐇✨

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.


Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 30th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between c3567ee and ada7305.

📒 Files selected for processing (3)
  • android/app/src/main/AndroidManifest.xml (2 hunks)
  • android/app/src/main/res/drawable/splash_background.xml (1 hunks)
  • android/app/src/main/res/values/styles.xml (1 hunks)
🔇 Additional comments (4)
android/app/src/main/res/drawable/splash_background.xml (1)

1-5: Approve new splash background drawable.

Defining a simple white rectangular shape as the splash background via a drawable resource is clean, lightweight, and follows Android resource conventions.

android/app/src/main/res/values/styles.xml (1)

18-22: Approve new SplashTheme definition.

Adding SplashTheme that inherits from Theme.AppCompat.Light.NoActionBar and applies @drawable/splash_background to android:windowBackground correctly encapsulates the splash screen style.

android/app/src/main/AndroidManifest.xml (2)

13-13: Approve application of SplashTheme to MainActivity.

Assigning android:theme="@style/SplashTheme" ensures the native splash background is displayed on app launch without altering existing logic.


25-27: Approve splash drawable metadata for Flutter embedding.

The <meta-data> with io.flutter.embedding.android.SplashScreenDrawable correctly links the splash background drawable to the Flutter engine, enabling the native splash screen.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@AliAkrem AliAkrem closed this May 21, 2025
@AliAkrem AliAkrem deleted the feat/native-android-splash-screen branch May 21, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants