Conversation
- the payload is not split into chunks. We require the user to provide a bigger buffer and we use part of it as excess to store entire tokens. The channel logic remains unchanged and it allows you to push only MAX_TOKENS * TOKEN_SIZE - channels take into account both how many tokens are in the channel and the available space - extended the isFull function to take a size_t and compute whether the channel is full - add extensive testing
25df1a7 to
7c09f5a
Compare
51bd5d5 to
50a4d4e
Compare
Coverage arm64
Minimum allowed line rate is |
Coverage amd64
Minimum allowed line rate is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Variable size SPSC channel:
- a single push that fills the payload buffer
- a series of push that fills the payload buffer
- a series of push that fills the coordination buffer
- push-pop-push with a buffer big enough to force the second push to use the excess buffer
Type of change
CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Verification
Added mpi test for variable size spsc channel