Skip to content

reference and reference_omp grb::dot do not handle aliasing properly #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
djelovina wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

reference and reference_omp grb::dot do not handle aliasing properly #413

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
338b2bf
Silence uninitialized warnings in dot_generic
Feb 19, 2026
ffed762
Implement NormPartial type and add norm2 function; enforce vector ali…
Feb 20, 2026
882d88b
more dot(x,x) captured by assertion
Feb 20, 2026
32f4b51
Replace dot product with norm2 in fuselets to avoid vector aliasing
Feb 23, 2026
9a5cfbf
Merge branch 'develop' into 387-reference-and-reference_omp-grbdot-do…
djelovina Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion include/graphblas/reference/blas1.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9438,7 +9438,10 @@ namespace grb {
// if apply surely initialises zz, we could use a blend-like op
for( size_t k = 0; k < AnyOp::blocksize; ++k ) {
if( mask[ k ] ) {
apply( zz[ k ], xx[ k ], yy[ k ], anyOp );
GRB_UTIL_IGNORE_MAYBE_UNINITIALIZED // yy and xx cannot be used
// uninitialised or mask
Copy link
Copy Markdown
Collaborator Author

@djelovina djelovina Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The compiler warning form #387 warnings disappear if re guard apply with GRB_UTIL_IGNORE_MAYBE_UNINITIALIZED and GRB_UTIL_RESTORE_WARNINGS, just like in the block before. This should be safe since the warning is false-positive.

apply( zz[ k ], xx[ k ], yy[ k ], anyOp ); // would be false while zz
GRB_UTIL_RESTORE_WARNINGS // init is just above
} else {
zz[ k ] = addMonoid.template getIdentity< typename AnyOp::D3 >();
}
Expand Down