[8.1-stable] Fix ingredient editor nested attributes index collision#3799
Merged
tvdeyen merged 1 commit into8.1-stablefrom Mar 27, 2026
Merged
[8.1-stable] Fix ingredient editor nested attributes index collision#3799tvdeyen merged 1 commit into8.1-stablefrom
tvdeyen merged 1 commit into8.1-stablefrom
Conversation
The form_field_counter method used the ingredient's position in the YAML element definition to generate the nested attributes index. This caused collisions where two ingredients could end up with the same index, corrupting form data on save. Use the ingredient's database ID as the nested attributes key instead. Rails accepts_nested_attributes_for does not require sequential indices, it only needs unique keys to group fields for each record. Since each ingredient has a unique ID, this eliminates any possibility of collision. Signed-off-by: Thomas von Deyen <vondeyen@blish.cloud> (cherry picked from commit 31fabf1)
3 tasks
tvdeyen
approved these changes
Mar 27, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 8.1-stable #3799 +/- ##
===========================================
Coverage 97.45% 97.45%
===========================================
Files 314 314
Lines 8330 8330
===========================================
Hits 8118 8118
Misses 212 212 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.1-stable:Questions ?
Please refer to the Backport tool documentation