Draft
Conversation
tvdeyen
force-pushed
the
preview-time-select
branch
13 times, most recently
from
336532f to
c266b1a
Compare
tvdeyen
force-pushed
the
preview-time-select
branch
3 times, most recently
from
b6bea99 to
dee842c
Compare
tvdeyen
force-pushed
the
preview-time-select
branch
from
d7ae1ab to
297f804
Compare
If this module is included in a controller out of the Alchemy::Admin scope we need to make sure we do not set the time zone.
The list of timezones is extremely long and a type ahead is better ux in this case. Signed-off-by: Thomas von Deyen <vondeyen@blish.cloud>
Defaults to Time.current but allows to globally control the time when we consider elements and pages to be public. Signed-off-by: Thomas von Deyen <vondeyen@blish.cloud>
…ements Alchemy now supports previewing pages as they will appear at a specific point in time. This allows content editors to verify that scheduled elements will publish and unpublish correctly. The feature adds a preview_at attribute to Alchemy::Current which is used globally by the Publishable concern to determine element visibility. When a datetime is selected in the toolbar, both the page preview iframe and the elements sidebar reload with time-filtered content. The published scope and public? method on all publishable records (elements, page versions) respect this setting, falling back to Time.current when not set. Signed-off-by: Thomas von Deyen <vondeyen@blish.cloud>
tvdeyen
force-pushed
the
preview-time-select
branch
from
297f804 to
8703014
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3789 +/- ##
==========================================
+ Coverage 97.48% 97.49% +0.01%
==========================================
Files 320 322 +2
Lines 8497 8551 +54
==========================================
+ Hits 8283 8337 +54
Misses 214 214 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Rebuilt assets after source or dependency changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Describe you pull request here...
Closes # (Remove if not related to any issue)
Notable changes (remove if none)
Explain any changes (maybe breaking?) that have been made.
Screenshots
Remove if no visual changes have been made.
Checklist