fix: remediate gobinary vulnerabilities in scanner-trivy#46
Merged
yuzichen12123 merged 3 commits intoApr 21, 2026
Conversation
- bump Go directive to 1.26.2\n- upgrade vulnerable modules (docker/cli, docker, go-redis, x/net, containerregistry)\n- remove legacy go-containerregistry replace\n- adapt SBOM artifact detection to new go-containerregistry API\n- update related unit test for manifest artifact type handling
🤖 AI Code Review
SummaryThis PR upgrades vulnerable Go dependencies and removes the custom go-containerregistry fork in favor of upstream v0.21.4. Key changes include Go 1.24.0→1.26.2, Trivy v0.48.3→v0.70.0, and API adjustments for the new go-containerregistry that moves from Review Statistics
Warnings
Suggestions
Positive Feedback
ℹ️ About this reviewThis review was automatically generated using the
|
alaudabot
reviewed
Apr 21, 2026
| @@ -1,23 +1,23 @@ | |||
| module github.com/aquasecurity/harbor-scanner-trivy | |||
|
|
|||
There was a problem hiding this comment.
Warning (bug/compatibility): Go version upgrade from 1.24.0 to 1.26.2 is a significant jump. Ensure comprehensive testing passes with the new Go version.
| setup: | ||
| curl -sfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh| sh -s v1.21.0 | ||
| curl -sfL https://raw.githubusercontent.com/aquasecurity/trivy/main/contrib/install.sh | sh -s -- -b /usr/local/bin v0.48.3 | ||
| curl -sfL https://raw.githubusercontent.com/aquasecurity/trivy/main/contrib/install.sh | sh -s -- -b /usr/local/bin v0.70.0 |
There was a problem hiding this comment.
Warning (bug/compatibility): Trivy version upgrade from v0.48.3 to v0.70.0 is a major version jump (22 minor versions). Please verify no breaking changes in the scanner functionality.
| fakeImage := &fake.FakeImage{} | ||
| fakeImage.ManifestReturns(&v1.Manifest{ | ||
| ArtifactType: "application/vnd.goharbor.harbor.sbom.v1", | ||
| Config: v1.Descriptor{ |
There was a problem hiding this comment.
Suggestion (test/coverage): Consider adding a test case that sets Manifest.ArtifactType directly to ensure full coverage of the partial.ArtifactType function behavior, not just the Config.MediaType fallback path.
- replace removed mutate.ArtifactType with mutate.ConfigMediaType\n- normalize layer metadata in SBOM vulnerability assertion to avoid version-specific DiffID drift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Result