Merged
Conversation
rtipper1
approved these changes
Apr 14, 2026
Collaborator
rtipper1
left a comment
rtipper1
left a comment
There was a problem hiding this comment.
Looks good for now, we will have to test once map is updated. That will be a later issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note:
Heading in the returned instructions is off by 180 deg. Tabling this for a future fix because map is changing anyway.
Because the heading in the map is off by 180 deg, the path recalculation is broken, not fixing it for this update for same reason.
Nodes in the instruction list are as expected to start and given the heading is correct, so the path calculated can fixed esily once the map is updated.