Fix markMentionsRead() for albums and action messages#404
Open
Azq2 wants to merge 3 commits intoAjaxy:masterfrom
Open
Fix markMentionsRead() for albums and action messages#404Azq2 wants to merge 3 commits intoAjaxy:masterfrom
Azq2 wants to merge 3 commits intoAjaxy:masterfrom
Conversation
👷 Deploy request for telegram-tt-previews pending review.Visit the deploys page to approve it
|
zubiden
reviewed
Jan 28, 2025
Comment on lines
+855
to
+861
| unreadMentionsIds.push(message.id); | ||
| } | ||
|
|
||
| if (album) { | ||
| for (const albumMessage of album.messages) { | ||
| if (albumMessage.hasUnreadMention) { | ||
| unreadMentionsIds.push(albumMessage.id); |
Contributor
There was a problem hiding this comment.
That would duplicate the main message id in albums. You could make unreadMentionIds re-assignable and write it like
if (album) {
unreadMentionIds = album.messages.filter((msg) => msg.hasUnreadMention).map((msg) => msg.id);
}
Author
There was a problem hiding this comment.
Sorry for the delay. I made an improvement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two related but independent issues.
For “system” messages (ActionMessage) the
markMentionsRead()is never called.For messages with albums (which actually consist of multiple messages),
markMentionsRead()was called only for the first message, and not for all submessages.Both these problems create problem, where unread mentions are just accumulated to infinity.
In my opinion, this is the most annoying bug in Telegram Web.