fix: pinned chats are toggled as selected when editing folder#322
Open
evgenii-minkov wants to merge 2 commits intoAjaxy:masterfrom
Open
fix: pinned chats are toggled as selected when editing folder#322evgenii-minkov wants to merge 2 commits intoAjaxy:masterfrom
evgenii-minkov wants to merge 2 commits intoAjaxy:masterfrom
Conversation
ea887db to
0f4c0d6
Compare
Contributor
|
Unfortunately, there is a bug in the implementation. 2023-12-12.21.25.27.mov |
0f4c0d6 to
01e5dc0
Compare
Author
|
@korenskoy thank you for pointing this out. i followed your guide and reproduced the behavior i did a quick research and discovered the root of the issue:
what i did is:
this fixes the behavior you showed in the video, but i do not particularly like what i'm doing here - this solution is an attempt to keep up with the separation of folder chats into included and pinned |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
there is currently a bug
Expected: Pinned chats are marked as selected as well as unpinned
Current: Pinned chats are marked as unselected and can be "added" to the folder
proposed changes in this PR address that by modifying 'selectChatFilters' selector and 'editChatFolders' action handler
side-note: i understand that pinned chat ids are not stored as a subset of included chat ids during initial API fetches for the purposes of ordering during render