Pull request for issue #34 #37
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a DOM pruning mechanism to the infinite scroll feature for displaying vocabulary lists. Previously, as the user scrolled, new table rows were continuously added to the DOM, but old rows that scrolled out of view were never removed. This led to an ever-growing number of DOM elements, causing significant performance degradation and crashes on memory-constrained devices like older iPads, especially when displaying more than 80-100 rows. This change addresses the issue by: 1. Introducing a `MAX_ROWS_IN_DOM` constant to limit the total number of `<tr>` elements that can exist in the DOM at any given time. 2. Adding a `pruneOffscreenRows` function that removes rows from the top or bottom of the table when the total number of rows exceeds the defined limit. 3. Updating the `scrollHandler` to call this pruning function after new rows are added, ensuring the DOM size remains small and constant, thus improving performance and preventing crashes. 4. Adding a global tracker `g_currentlyRendered` to keep track of the rendered data slice.
Contributor
Author
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll acknowledge your comments with a 👀 emoji and then get to work. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! I will automatically address your feedback. For any comments you don't want me to act on, just include (aside). For security, I will only act on instructions from the user who triggered this task for this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34
PR created automatically by Jules for task 6457327844237072953