#12 - add a flatten pom step to fix published pom.xml #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbernard31
reviewed
Dec 4, 2025
Contributor
sbernard31
left a comment
sbernard31
left a comment
There was a problem hiding this comment.
I'm not sure I get which artefacts are deployed but ideally the root module proxy-socket-java should not.
sbernard31
approved these changes
Dec 4, 2025
Contributor
sbernard31
left a comment
sbernard31
left a comment
There was a problem hiding this comment.
It sounds good.
(Just I don't like so much that files generated at build time are not in target repository : I talk about .flattened-pom.xml but this is not a blocking issue)
sbernard31
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added forgotten "flattening" step of https://maven.apache.org/guides/mini/guide-maven-ci-friendly.html
Also fixed the release action to download the whole repository to have the tags, however maybe
fetch-deps: 1+fetch-tags: truewould be good also, created #14 for this.