Skip to content

Trim user input before sending to detectSqlInjection #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bitterpanda63 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Trim user input before sending to detectSqlInjection #291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f2411a1
Trim user input before sending to detectSqlInjection
bitterpanda63 Jun 1, 2026
6f3854d
Update test: strip normalizes whitespace-only wrappers around numbers
bitterpanda63 Jun 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/aikido/zen/scanners/sql_injection_scanner.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ def self.call(query:, dialect:, scan:, sink:, context:, operation:)

def initialize(query, input, dialect)
@query = query.downcase
@input = input.downcase
@input = input.downcase.strip
@dialect = dialect
end

Expand Down
13 changes: 10 additions & 3 deletions test/aikido/zen/scanners/sql_injection_scanner_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,13 @@ def refute_attack(query, input = query, *args)
assert_attack "SELECT id FROM users WHERE email = '' or 1=1 -- a'", "' OR 1=1 -- a"
end

test "detects injection when user input has trailing spaces" do
assert_attack(
"INSERT INTO pets (name, owner) VALUES ('x', 'dummy'), ('injected', 'hacker'); --', 'owner')",
"x', 'dummy'), ('injected', 'hacker'); -- "
)
end

test "it does not flag VIEW as an attack when it's a substring" do
query = <<~SQL.chomp
SELECT views.id AS view_id, view_settings.user_id, view_settings.settings
Expand Down Expand Up @@ -254,9 +261,9 @@ def refute_attack(query, input = query, *args)
refute_attack "SELECT * WHERE id = 123 ", " 123 "
end

test "flags invalid whitespace around numbers" do
assert_attack "SELECT * WHERE id = \n123\n", "\n123\n"
assert_attack "SELECT * WHERE id = \t123\t", "\t123\t"
test "ignores leading/trailing whitespace around numbers" do
refute_attack "SELECT * WHERE id = \n123\n", "\n123\n"
refute_attack "SELECT * WHERE id = \t123\t", "\t123\t"
end

test "ignores comma-separated list of numbers" do
Expand Down
Loading