Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
package dev.aikido.agent_api.helpers.net;

import java.net.IDN;

public final class NormalizeHostname {
private NormalizeHostname() {}

/**
* Canonicalizes a hostname for consistent comparison: lowercases, strips a
* trailing dot (FQDN form returned by some DNS resolvers), and converts
* Punycode labels to Unicode via IDN.
*/
public static String normalize(String hostname) {
if (hostname == null || hostname.isEmpty()) {
return hostname;
}
String lower = hostname.toLowerCase();
String noDot = lower.endsWith(".") ? lower.substring(0, lower.length() - 1) : lower;
try {
return IDN.toUnicode(noDot);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need this? if a DNS request is made to a host with punycode, it isn't converted to unicode by java's getallbyname

} catch (Exception e) {
return noDot;
}
}
}
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
package dev.aikido.agent_api.vulnerabilities.ssrf.imds;

import dev.aikido.agent_api.helpers.net.NormalizeHostname;
import java.util.Arrays;
import java.util.HashSet;
import java.util.Set;

public final class TrustedHosts {
private TrustedHosts() {}
Expand All @@ -13,6 +12,6 @@ private TrustedHosts() {}

/** Checks if this hostname is trusted */
public static boolean isTrustedHostname(String hostname) {
return Arrays.asList(trustedHosts).contains(hostname);
return Arrays.asList(trustedHosts).contains(NormalizeHostname.normalize(hostname));
}
}
40 changes: 40 additions & 0 deletions agent_api/src/test/java/helpers/net/NormalizeHostnameTest.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
package helpers.net;

import dev.aikido.agent_api.helpers.net.NormalizeHostname;
import org.junit.jupiter.api.Test;

import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertNull;

class NormalizeHostnameTest {

@Test
void testNullAndEmpty() {
assertNull(NormalizeHostname.normalize(null));
assertEquals("", NormalizeHostname.normalize(""));
}

@Test
void testLowercases() {
assertEquals("example.com", NormalizeHostname.normalize("EXAMPLE.COM"));
assertEquals("metadata.google.internal", NormalizeHostname.normalize("METADATA.GOOGLE.INTERNAL"));
}

@Test
void testStripsTrailingDot() {
assertEquals("example.com", NormalizeHostname.normalize("example.com."));
assertEquals("metadata.google.internal", NormalizeHostname.normalize("metadata.google.internal."));
assertEquals("metadata.goog", NormalizeHostname.normalize("metadata.goog."));
}

@Test
void testStripsTrailingDotAndLowercases() {
assertEquals("metadata.google.internal", NormalizeHostname.normalize("METADATA.GOOGLE.INTERNAL."));
}

@Test
void testPlainHostnameUnchanged() {
assertEquals("example.com", NormalizeHostname.normalize("example.com"));
assertEquals("localhost", NormalizeHostname.normalize("localhost"));
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -85,4 +85,13 @@ void testResolvesToImdsIp_WithMultipleResolvedIps_OnlyTrustedHostname() {

assertNull(Resolver.resolvesToImdsIp(resolvedIps, "metadata.google.internal"));
}

@Test
void testResolvesToImdsIp_TrustedHostnameWithTrailingDot() {
Set<String> resolvedIps = new HashSet<>();
resolvedIps.add("169.254.169.254"); // IMDS IP

assertNull(Resolver.resolvesToImdsIp(resolvedIps, "metadata.google.internal."));
assertNull(Resolver.resolvesToImdsIp(resolvedIps, "metadata.goog."));
}
}
Loading