Handle variable MultiDiGraph out-edge tuple shapes in repo map#4921
Open
biefan wants to merge 1 commit intoAider-AI:mainfrom
Open
Handle variable MultiDiGraph out-edge tuple shapes in repo map#4921biefan wants to merge 1 commit intoAider-AI:mainfrom
biefan wants to merge 1 commit intoAider-AI:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Handle repo map graph edge tuples without assuming a fixed tuple length.
Problem
get_ranked_tags()currently unpacks eachMultiDiGraph.out_edges(..., data=True)item as(src, dst, data). In environments where the multiedge view includes an edge key, that assumption breaks and repo map generation crashes with aValueErrorwhile distributing rank across outgoing edges.Root cause
The code assumed a fixed edge tuple shape even though
MultiDiGraphedge views can vary depending on how the view is produced. The actual logic only needs the destination node and the edge data, not the exact tuple layout.Fix
dstanddatapositionally so both 3-item and 4-item edge tuples worknetworkx.MultiDiGraphto expose keyed out-edges and verifies repo map generation still succeedsValidation
./.venv311/bin/python -m pytest tests/basic/test_repomap.py -q./.venv311/bin/python -m flake8 aider/repomap.py tests/basic/test_repomap.pyFixes #4917.