⚡ Bolt: Optimize text search by skipping line counting for non-matching files#227
Conversation
…matching files Refactor `processBufferLines` to accept an `isWholeFile` flag. When scanning a whole file (e.g. small files < 50KB) and no matches are found, return immediately instead of performing an O(N) scan for newlines. This saves CPU cycles for the majority of files that do not match the query. Verified with regression tests in `stream-search.test.ts`. Co-authored-by: AhmmedSamier <17784876+AhmmedSamier@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
AhmmedSamier
deleted the
bolt-optimize-text-search-skip-scan-17449568065765578872
branch
1 participant
💡 What: Optimized
SearchEngine.processBufferLinesto skipadvanceLinesWithoutMatcheswhen scanning the entire file content and finding no matches.🎯 Why:
advanceLinesWithoutMatchesperforms an O(N) scan (where N is file size) to count newlines. This is unnecessary if we are processing the whole file at once and there are no matches, as the line count is not used by the caller in this case.📊 Impact: Reduces CPU time for text search on non-matching small files (<50KB). Micro-benchmark showed a massive reduction (0.04ms -> ~0ms) per file. For 10,000 files, this could save ~400ms of blocking CPU time.
🔬 Measurement: Verified with
bun test language-server/src/tests/stream-search.test.tsincluding a new test case for the optimization path.PR created automatically by Jules for task 17449568065765578872 started by @AhmmedSamier