⚡ Bolt: Optimize indexer worker concurrency#226
Conversation
… concurrency Refactors `indexer-worker.ts` to use `p-limit` for file processing instead of fixed-size chunks. This prevents head-of-line blocking where a single slow file in a chunk delays the processing of subsequent files. - Replaces `for` loop chunking with `pLimit` based concurrent execution. - Implements internal result buffering to maintain batched IPC reporting (reducing message overhead) while allowing tasks to complete independently. - Ensures robust `isPartial` flag handling to signal task completion correctly. - Verified with custom `verify-worker.ts` script and existing test suite. Co-authored-by: AhmmedSamier <17784876+AhmmedSamier@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
AhmmedSamier
deleted the
bolt/indexer-worker-concurrency-3706162459365039895
branch
1 participant
💡 What: Replaced the fixed-chunk processing loop in
indexer-worker.tswith ap-limitbased concurrency model.🎯 Why: The previous implementation processed files in batches (e.g., 25 files), waiting for all files in the batch to complete before starting the next batch. This caused "head-of-line blocking" where one slow file would idle the worker thread for the duration of the batch.
📊 Impact: Eliminates idle time between batches. Workers can now process files as soon as a slot opens up. This improves indexing throughput for mixed workloads (small and large files).
🔬 Measurement: Verified functionality with
verify-worker.ts(ensuring correct partial/final message protocol) and ran existing tests (bun run testinlanguage-server).PR created automatically by Jules for task 3706162459365039895 started by @AhmmedSamier