⚡ Bolt: Optimize SearchEngine ingestion (54% faster)#223
Conversation
- Remove `ensureBitflagsInitialized` from `calculateBitflags` hot loop, calling it instead at entry points (`setItems`, `addItems`, `search`). - Add 1-item cache for `normalizedPath` in `populateParallelArrays` to avoid redundant string normalization/allocations for consecutive items from the same file. - Suppress `sonarjs/cognitive-complexity` on `removeItemsByFiles` (pre-existing complexity). This reduces `setItems` time by ~54% (1950ms -> 897ms for 65k items) by eliminating overhead in the tight ingestion loop. Co-authored-by: AhmmedSamier <17784876+AhmmedSamier@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
…athcache-5974122981483365903
Rename variable for clarity and consistency with lastRelativeOutput.
AhmmedSamier
deleted the
bolt/search-engine-optimization-bitflags-pathcache-5974122981483365903
branch
1 participant
💡 What: Optimized
SearchEngine.calculateBitflagsby hoisting the initialization check out of the hot loop, and added a 1-item cache for path normalization inpopulateParallelArrays.🎯 Why: Profiling/Benchmarking revealed that
calculateBitflags(called 3x per item) andreplaceAll(called 1x per item) were significant overheads during ingestion (setItems/addItems).📊 Impact: Reduces
setItemsexecution time by ~54% (from ~1.95s to ~0.9s for 65k items).🔬 Measurement: Verified with a reproduction script (
language-server/repro.ts) measuringsetItemsperformance. Ran existing tests to ensure no regressions.PR created automatically by Jules for task 5974122981483365903 started by @AhmmedSamier