Skip to content

🐛 Copy the result data instead of referencing directly #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
peilinok merged 2 commits into from
Apr 15, 2025
Merged

🐛 Copy the result data instead of referencing directly #113

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3206b9a
🐛 Copy the result data instead of referencing directly
AlexV525 Feb 19, 2025
2e43595
⚡️ Ensure `CallApiResult` is immutable but provide a factory constructor
AlexV525 Feb 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 20 additions & 4 deletions lib/src/platform/iris_method_channel_interface.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import 'dart:typed_data';

import 'package:flutter/foundation.dart' show VoidCallback, SynchronousFuture;
import 'package:flutter/foundation.dart'
show VoidCallback, SynchronousFuture, immutable;
import 'package:iris_method_channel/src/iris_handles.dart';
import 'package:iris_method_channel/src/platform/iris_event_interface.dart';
import 'package:iris_method_channel/src/scoped_objects.dart';
Expand All @@ -17,12 +18,27 @@ class BufferParam {
final int length;
}

@immutable
class CallApiResult {
CallApiResult(
{required this.irisReturnCode, required this.data, this.rawData = ''});
factory CallApiResult({
required Map<String, dynamic> data,
required int irisReturnCode,
String rawData = '',
}) {
return CallApiResult._(
data: Map<String, dynamic>.from(data),
irisReturnCode: irisReturnCode,
rawData: rawData,
);
}

final int irisReturnCode;
const CallApiResult._({
required this.irisReturnCode,
required this.data,
this.rawData = '',
});

final int irisReturnCode;
final Map<String, dynamic> data;

// TODO(littlegnal): Remove rawData after EP-253 landed.
Expand Down
Loading