Skip to content

fix(handlers): stop flaky coverage CI from global-logger race in parallel tests #603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AbirAbbas wants to merge 1 commit into from
+9 −2
Closed

fix(handlers): stop flaky coverage CI from global-logger race in parallel tests #603

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions control-plane/internal/handlers/coverage_handlers_92_target_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,11 @@ func TestAgentConcurrencyLimiter_MaxPerAgentNilAndConfigured(t *testing.T) {
}

func TestExecutionCleanupService_StartStopBranches(t *testing.T) {
t.Parallel()
// NOT t.Parallel(): this test swaps the process-global logger.Logger via
// setupExecutionCleanupTestLogger. Running it in parallel let a sibling test
// reassign the global logger mid-run, contaminating log buffers and flaking
// the coverage CI job. Keep it in the serial phase, like the other
// logger-swapping tests in execution_cleanup_test.go.

t.Run("disabled start is no-op", func(t *testing.T) {
service := NewExecutionCleanupService(&cleanupStoreMock{}, config.ExecutionCleanupConfig{Enabled: false})
Expand Down Expand Up @@ -341,7 +345,10 @@ func TestIsLightweightRequestQueryVariants(t *testing.T) {
}

func TestDiscoveryLoggingIncludesOptionalRequestID(t *testing.T) {
t.Parallel()
// NOT t.Parallel(): this test swaps the process-global logger.Logger via
// setupExecutionCleanupTestLogger and then asserts on the captured buffer.
// In parallel, a sibling test reassigning the global logger emptied this
// buffer and flaked the coverage CI job. Keep it in the serial phase.
gin.SetMode(gin.TestMode)

logBuffer := setupExecutionCleanupTestLogger(t)
Expand Down
Loading