catch JSON parsing errors in fbgraph

[eawooten]

This pull request improves the robustness of JSON parsing in the Graph class by adding error handling for malformed JSON responses. It also introduces new tests to verify that the application handles non-JSON responses gracefully instead of crashing.

Error handling improvements:

• Updated Graph.prototype.get and Graph.prototype.post in lib/graph.js to wrap JSON parsing in a try/catch block, ensuring that parsing errors do not crash the application and that raw bodies are passed to end() if parsing fails. [1] [2]

Testing enhancements:

• Added a new test batch in tests/graph.test.js to simulate receiving a malformed JSON response and verify that the error is handled correctly, returning an error instead of crashing.
• Imported the request module in tests/graph.test.js to enable mocking of HTTP requests for the new tests.

[Copilot]

Pull request overview

This PR hardens fbgraph’s HTTP response handling by preventing unhandled exceptions when parsing response bodies as JSON, and adds a regression test to ensure malformed JSON doesn’t crash the client.

Changes:

• Wrap JSON.parse in Graph.prototype.get/post with try/catch to avoid crashing on invalid JSON.
• Check for image responses before attempting JSON parsing in get.
• Add a Vows test that stubs request.get to return malformed JSON and asserts an error is returned.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File	Description
lib/graph.js	Adds defensive try/catch around JSON parsing in get/post and reorders image detection to avoid parsing binary/image responses.
tests/graph.test.js	Adds a new batch that stubs request.get to validate malformed JSON is surfaced as an error instead of throwing.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[pmg-sevenonethree]

do we need to somehow reset this back to what it was?

[eawooten]

I believe that's line 296 below