sending Isobus type PGN#1164
sending Isobus type PGN#1164Pat-I wants to merge 12 commits intoAgOpenGPS-Official:readyforreleasefrom
Conversation
This change the AOG PGN 0xF2 to also send the CANBUS PGN number, his priority, source and destination address. It now also send all 8 data byte of the ISOBUS Process Data Message (DDEntity) The AOG message is now 7 bytes longer.
1:1 J1939 CANBUS message fist 4 bytes make the identifier 8 next bytes are the payload
reversed the Frame identifier byte order.
|
I made some changes Edited to remove the inaccurate test results. |
corrected a comment after further tests
This extra byte will allow to send some instruction with the CAN message. Like a command to send on the machine bus for example. This PGN could eventually be used from and to any device in AOG.
|
Description of the proposed modified AOG PGN F2: Example: ISOBUS PGN: 0xCB00, priority: 3, DA(PS): F7, SA: 82 On CANBUS: 0xCCBF782, 53, 0, 4B, 0, 14, B6, 3A, 0 Overall the cost is 7 more bytes (+58%) and the benefit is to be able send (almost?) any CAN J1939 message between controllers in AOG |
Allow sending variable length CANBUS message The ISOBUS process data message is still fixed to 8 bytes
Put it to 3
allow variable data length for 0xCB00 Some parameters are optional
|
The last commit allow "private void SendCanbusMessage(int id, byte[] data)" to send a variable number of "data" bytes. There's no limit of bytes for this PGN although CANBUS is 1 to 8 bytes. |
Removed F1 to replace by F2 DDE160
Output the ISOBUS setpoint Condensed Work State DDE290 +
fix to be able to read 8 byte standard length PGNs Fixed section painting behavior if the sections are ON while a field is opened or closed.
| number |= 1ul << j; | ||
| } | ||
| } | ||
| if (!isJobStarted) number = 0; // |
There was a problem hiding this comment.
Can the variable number be changed to something appropriate?
There was a problem hiding this comment.
I did not choose this name. I only set it to 0 in 2 more situations
2 participants
This change the AOG PGN 0xF2 to also send the CANBUS PGN number, his priority, source and destination address.
It now also send all 8 data byte of the ISOBUS Process Data Message (DDEntity)
The AOG message is now 7 bytes longer.
Right now it only send the "ISOBUS Process Data Message (DDEntity)", PGN 0xCB00(51968):
The goal of this change is to be able to exchange more isobus data in the future without having to create other PGNs (at the cost of more data sent today).