Fix/asyncsession to asyncsessionmaker#41
Open
abdelrahmanthelion142-a11y wants to merge 9 commits intoAeternalis-Ingenium:trunkfrom
Open
Fix/asyncsession to asyncsessionmaker#41abdelrahmanthelion142-a11y wants to merge 9 commits intoAeternalis-Ingenium:trunkfrom
abdelrahmanthelion142-a11y wants to merge 9 commits intoAeternalis-Ingenium:trunkfrom
Conversation
…b.com/abdelrahmanthelion142-a11y/FastAPI-Backend-Template into fix/asyncsession-to-asyncsessionmaker
…b.com/abdelrahmanthelion142-a11y/FastAPI-Backend-Template into fix/asyncsession-to-asyncsessionmaker
Author
|
there was some issues with some typos in Dockerfile and README.MD that caused the pre-commit checks to fail but i fixed them |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix critical async session issue by using AsyncSessionMaker
Hi Nino Lindenberg! 👋
I’ve been using your repo and really appreciate the work you’ve done. I wanted to contribute a small improvement and help make the template more robust.
Summary
Previously, the template used a single
AsyncSessioninstance for the entire application.While the app may run normally on startup, this pattern can cause serious concurrency issues and shared state conflicts when handling multiple requests asynchronously.
This PR replaces the global session with
AsyncSessionMaker, ensuring that each request or operation receives its own AsyncSession instance, which is the standard pattern for async SQLAlchemy + FastAPI.Usage Example (from a video by Corey Schafer on converting from sync SQLAlchemy to async)
YouTube Video
Notes