Conversation
hphilm
force-pushed
the
update/steamos-manager
branch
from
9783120 to
14672d3
Compare
Contributor
Author
|
Seems now to be ready for review. Proper squashing of the commits is needed. Just added as single commits for better understanding what I had done so far to this package-set. |
hphilm
force-pushed
the
update/steamos-manager
branch
from
af93b3c to
1370955
Compare
hphilm
force-pushed
the
update/steamos-manager
branch
from
1370955 to
f27dcb1
Compare
ermo
reviewed
Mar 27, 2026
Member
ermo
left a comment
ermo
left a comment
There was a problem hiding this comment.
Just a couple of packaging macro-related nits.
| %make | ||
| install : | | ||
| %make_install | ||
| rm %(installroot)/usr/share/defaults/speech-dispatcher/modules/cicero.conf |
Member
There was a problem hiding this comment.
Please use %(installroot)%(vendordir) for the rm statements.
| #sed -i -e 's/ -steamos3/ -steamos/;s/ -steampal//;s/ -steamdeck//' %(installroot)/usr/share/gamescope-session-plus/sessions.d/steam | ||
|
|
||
| # We ship our own update file | ||
| rm %(installroot)/usr/bin/steamos-update |
Member
There was a problem hiding this comment.
%(installroot)%(bindir) should be used here.
hphilm
force-pushed
the
update/steamos-manager
branch
from
f27dcb1 to
4fc8895
Compare
Contributor
Author
|
@ermo should be fine now ... |
ermo
approved these changes
Mar 28, 2026
Member
ermo
left a comment
ermo
left a comment
There was a problem hiding this comment.
We may want to do delete the static library in the future if nothing depends on it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This will add SteamOS Manager with its dependencies
Test Plan
Checklist