lichen: Filter timezone options based on locale#99
Open
otherJL0 wants to merge 12 commits intoAerynOS:mainfrom
Open
lichen: Filter timezone options based on locale#99otherJL0 wants to merge 12 commits intoAerynOS:mainfrom
otherJL0 wants to merge 12 commits intoAerynOS:mainfrom
Conversation
Member
|
It makes sense to me that more likely timezones would be presented to the user higher-up, but filtering sounds like the user won't be able to pick a different timezone at all - is that the case? |
abc6cd9 to
1c72653
Compare
Author
I originally added an escape hatch to select from all timezones at the end of the filtered list. I've made an update to show the option to see all timezones a the start of the list which I hope is a better user experience. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

During the installation process, all timezones from the
chrono-tzpackage are presented for the user to select from.This changes the default behavior by limiting the presented timezones based on the already selected locale information. The locale information is used to find relevant timezones in the
/usr/share/zoneinfo/zone1970.tabtable. This also allows the removal ofchrono-tzas a dependency.This also provides a simple escape hatch in case the user wants to select from all timezones independent of their locale.