Make NONE a Symbol; add unwrap/isNone#67
Merged
shgysk8zer0 merged 1 commit intomasterfrom Mar 3, 2026
Merged
Conversation
Replace NONE (previously null) with a unique Symbol so NONE is distinct from succeed(null); add utility functions isNone() and unwrap(result) and tighten ResultTuple/Success/Failure validations (prevent succeeding/failing with NONE, add toStringTag). Adjust async/sync attempt handling to avoid incorrect Promise.try usage and ensure attemptSync returns promises when needed. Update tests to expect NONE and include unwrap coverage. Also bump .nvmrc (Node 24), update CI npm install flags, update changelog and package metadata/dependencies accordingly.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace NONE (previously null) with a unique Symbol so NONE is distinct from succeed(null); add utility functions isNone() and unwrap(result) and tighten ResultTuple/Success/Failure validations (prevent succeeding/failing with NONE, add toStringTag). Adjust async/sync attempt handling to avoid incorrect Promise.try usage and ensure attemptSync returns promises when needed. Update tests to expect NONE and include unwrap coverage. Also bump .nvmrc (Node 24), update CI npm install flags, update changelog and package metadata/dependencies accordingly.
Description and issue
List of significant changes made