Skip to content

216 Evaluate yarn workspaces to accommodate nohoist feature#224

Draft
govind-srinidhi wants to merge 4 commits into200-investigate-a-way-to-develop-and-test-components-on-both-vue-versionsfrom
216-evaluate-yarn-workspaces
Draft

216 Evaluate yarn workspaces to accommodate nohoist feature#224
govind-srinidhi wants to merge 4 commits into200-investigate-a-way-to-develop-and-test-components-on-both-vue-versionsfrom
216-evaluate-yarn-workspaces

Conversation

@govind-srinidhi
Copy link
Copy Markdown
Contributor

@govind-srinidhi govind-srinidhi commented Jun 21, 2023

Relates to #216

📝 Description

Evaluate yarn and yarn-workspaces and check if it can be used instead of npm and npm-workspaces in Lume.

This PR covers following things:

  • Migration from npm and npm workspace to yarn and yarn workspace.
  • Ensuring that storybook and vue/test-utils are no longer hoisted in the root workspace.
  • Storybook upgrade to v7.
  • Separate storybook instances for Vue 2/3.
  • Update tests to work for both Vue 2 and 3

💥 Is this a breaking change (Yes/No):

  • No
  • Yes (please describe the impact and migration path for existing Lume users)
    Whenever the consumer install the new version released, clear the npm cache and install without legacy peer dependencies. Execute the following commands in sequence to achieve the same:
1) npm cache clean --force
2) npm install @adyen/lume --legacy-peer-deps

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@govind-srinidhi govind-srinidhi added the cicd an issue related to CI/CD or workflows label Jun 21, 2023
@govind-srinidhi govind-srinidhi self-assigned this Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cicd an issue related to CI/CD or workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant