Skip to content

[payout] Code generation: update services and models#1810

Open
AdyenAutomationBot wants to merge 1 commit intomainfrom
sdk-automation/payout
Open

[payout] Code generation: update services and models#1810
AdyenAutomationBot wants to merge 1 commit intomainfrom
sdk-automation/payout

Conversation

@AdyenAutomationBot
Copy link
Copy Markdown
Collaborator

This PR contains the automated changes for the payout service.

The commit history of this PR reflects the adyen-openapi commits that have been applied.

@AdyenAutomationBot AdyenAutomationBot requested review from a team as code owners March 27, 2026 11:26
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request cleans up unused imports in the MessageHeaderTest.java file. Feedback suggests enhancing the test suite by adding cases for optional fields in the MessageHeader to ensure they are correctly handled when absent from the JSON input.


import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertNotNull;
import static org.junit.jupiter.api.Assertions.assertNull;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The removal of the assertNull and assertNotNull imports suggests that test coverage for optional fields may be missing. The existing test only covers the happy path where all fields are present. To make the tests more robust, consider adding cases where optional MessageHeader fields (e.g., protocolVersion, serviceID, deviceID) are absent in the JSON. You can then assert that these fields are null after deserialization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant