Skip to content

Upgrade to go 1.23 #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wipsel merged 1 commit into from
Dec 22, 2024
Merged

Upgrade to go 1.23 #229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/go.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
- name: Set up Go
uses: actions/setup-go@v3
with:
go-version: 1.21
go-version: 1.23

- name: Install linter
run: make install_lint
Expand All @@ -34,7 +34,7 @@ jobs:
- name: Set up Go
uses: actions/setup-go@v3
with:
go-version: 1.21
go-version: 1.23

- name: Install dependencies
run: make install
Expand All @@ -56,7 +56,7 @@ jobs:
- name: Set up Go
uses: actions/setup-go@v3
with:
go-version: 1.21
go-version: 1.23

- name: Build amd64
run: make build_amd64
Expand All @@ -69,7 +69,7 @@ jobs:
- name: Set up Go
uses: actions/setup-go@v3
with:
go-version: 1.21
go-version: 1.23

- name: Build arm64
run: make build_arm64
3 changes: 1 addition & 2 deletions .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ linters:
- errchkjson
- errname
- errorlint
- execinquery
- exhaustive
- exportloopref
- forcetypeassert
Expand All @@ -19,7 +18,7 @@ linters:
- gocritic
- godot
- godox
- goerr113
- err113
- goprintffuncname
- govet
- ineffassign
Expand Down
4 changes: 2 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ VERSION=$(shell git describe --always --tags --dirty)
LDFLAGS=-ldflags "-s -w -X main.Version=${VERSION}"
TEST=$(shell go list ./... | grep -v /onnx/)

BUILD_PARAMS=CGO_ENABLED=0 ASSUME_NO_MOVING_GC_UNSAFE_RISK_IT_WITH=go1.21
BUILD_PARAMS=CGO_ENABLED=0


define echotask
Expand Down Expand Up @@ -33,7 +33,7 @@ lint: ## Run various linters.

test: ## Run tests using gotestsum.
@ ${BUILD_PARAMS} gotestsum \
--format=dots -- \
--format=dots-v2 -- \
-timeout=30000ms \
-covermode=set \
-coverprofile=.coverage.out ${TEST}
Expand Down
4 changes: 2 additions & 2 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
module github.com/advancedclimatesystems/gonnx

go 1.21
go 1.23

require (
github.com/pkg/errors v0.9.1
github.com/stretchr/testify v1.8.1
google.golang.org/protobuf v1.31.0
gorgonia.org/tensor v0.9.24
Expand All @@ -16,7 +17,6 @@ require (
github.com/gogo/protobuf v1.3.2 // indirect
github.com/golang/protobuf v1.5.3 // indirect
github.com/google/flatbuffers v23.5.26+incompatible // indirect
github.com/pkg/errors v0.9.1 // indirect
github.com/pmezard/go-difflib v1.0.0 // indirect
github.com/xtgo/set v1.0.0 // indirect
go4.org/unsafe/assume-no-moving-gc v0.0.0-20231121144256-b99613f794b6 // indirect
Expand Down
Loading