Merged
Conversation
This commit significantly overhauls the OpenSSL dependency handling for macOS builds in the GitHub Actions release workflow, specifically addressing issues you encountered during cross-architecture compilation (e.g., building for x86_64 on an ARM64 runner). Key changes to the macOS steps: - Dynamically determines the target architecture (x86_64 or ARM64) for OpenSSL. - Uses `arch -x86_64` with Homebrew commands when targeting x86_64 to ensure the correct version of OpenSSL is installed and queried, utilizing Rosetta 2 on ARM64 runners. - Sets `OPENSSL_DIR` to the precise Homebrew prefix of the architecture-specific OpenSSL installation. - Sets target-specific environment variables (e.g., `X86_64_APPLE_DARWIN_OPENSSL_DIR`, `AARCH64_APPLE_DARWIN_OPENSSL_DIR`) that the `openssl-sys` crate explicitly checks. - Prepends the correct OpenSSL `lib/pkgconfig` directory to `PKG_CONFIG_PATH` to guide `pkg-config` if it's used. - Includes more robust error checking for Homebrew prefix resolution. These changes are intended to resolve persistent OpenSSL build failures on macOS by ensuring that the build process can reliably locate the appropriate OpenSSL libraries and headers for the specified target architecture.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.