Add special case for saving model when running with ZERO-3 optimisation.#149
Open
Add special case for saving model when running with ZERO-3 optimisation.#149
Conversation
Signed-off-by: Szymon Duchniewicz <szymon.duchniewicz.20@ucl.ac.uk>
Collaborator
Author
|
Weird thing is: when saving the model, it saves it fine, but also saves the placeholder But |
Adamliu1
reviewed
Sep 18, 2024
|
|
||
| # Save final model. | ||
| if accelerator.is_local_main_process: | ||
| # NOTE: special case for zero 3 |
Owner
There was a problem hiding this comment.
why are we not handling model saving in the main process? I wonder
Collaborator
Author
There was a problem hiding this comment.
@Adamliu1 good q, I basedd this off of: https://huggingface.co/docs/accelerate/usage_guides/deepspeed#saving-and-loading , and I belive its because each process (on each of the 4 GPUs) has a portion of the model that needs to be synced across - hence cannot just unwrap it on a single process.
Signed-off-by: Szymon Duchniewicz <szymon.duchniewicz.20@ucl.ac.uk>
70ae769 to
837dd6e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tiny fix so a model sharded with Zero-3 can be saved! (To test if it doesnt also save the ugly placeholder confusing huggingface model loader)