Add ACTOutputStream: build an ACT on disk from a stream of ordered paths#54
Open
imlvts wants to merge 1 commit into
Open
Add ACTOutputStream: build an ACT on disk from a stream of ordered paths#54imlvts wants to merge 1 commit into
imlvts wants to merge 1 commit into
Conversation
Streams strictly-increasing paths into an on-disk ArenaCompactTree
without holding the trie in memory: a stack of in-construction frames
(one per byte of the current path) is sealed bottom-up whenever the
input diverges, writing each node's children contiguously as the
format requires and folding non-branching runs into line nodes.
Reuses the existing FileDumper writer, including line-data dedup.
let mut b = ACTOutputStream::new("file.act")?;
b.push("123")?;
b.push_val("124", 42)?;
let tree = b.finish()?; // mmap-backed ArenaCompactTree
Also fixes a pre-existing out-of-bounds walk in get_val_at: it never
checked the branch bytemask before index_of/nth_node, so looking up a
byte absent from a branch with children stepped past the last sibling
into unrelated arena bytes (subtract-overflow panic in debug builds).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Streams strictly-increasing paths into an on-disk ArenaCompactTree without holding the trie in memory: a stack of in-construction frames (one per byte of the current path) is sealed bottom-up whenever the input diverges, writing each node's children contiguously as the format requires and folding non-branching runs into line nodes. Reuses the existing FileDumper writer, including line-data dedup.
Also fixes a pre-existing out-of-bounds walk in get_val_at: it never checked the branch bytemask before index_of/nth_node, so looking up a byte absent from a branch with children stepped past the last sibling into unrelated arena bytes (subtract-overflow panic in debug builds).