Fix and simplify build of static libraries.#3
Open
asarhaddon wants to merge 1 commit intoAdaCore:masterfrom
Open
Fix and simplify build of static libraries.#3asarhaddon wants to merge 1 commit intoAdaCore:masterfrom
asarhaddon wants to merge 1 commit intoAdaCore:masterfrom
Conversation
This was referenced Oct 11, 2020
Member
|
HI @asarhaddon thanks for your contribution. You should have a look at this change: d49ff15 |
7389eb1 to
41cb918
Compare
Contributor
Author
|
This commit should hopefully fix the initial problem (some Debian architectures are missing a static archiver). A separate merge request (#4) fixes a probable typo. You are right that the remaining idea is similar to d49ff15.
|
41cb918 to
0f68f97
Compare
t-14
requested changes
Sep 9, 2022
Contributor
t-14
left a comment
There was a problem hiding this comment.
Unfortunately, due to a veritable zoo of architectures that AdaCore has to support, this patch is problematic for us as is. May I suggest that you just add specific triplets you would like to exclude, but leave the generic regexes intact?
This covers both native and cross builds, as /usr/bin/TARGET-ar exists in both cases.
0f68f97 to
49a70ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gprconfig was generating no Archive_Builder attribute for
mips-linux-gnu, powerpc64le-linux-gnu and many other architectures,
because the regular expressions defining specific architectures and
the fallback were not covering all cases. Ensure that all cases are
covered by the fallback stanza.
Replace many handwritten copies with variable substitutions.
Merge i686-pc-mingw32 and x86_64-pc-mingw32 as already done for other
architectures with aliases.
Merge native x86 into the default stanza.
This merge request was
AdaCore/gprbuild#67 before the split to gprconfig-kb.
This merge request is causing, for at least the third time, a non-trivial merge conflict.
A recent conflict (d9e1487) introduces an error (unless "-ranlib" is a valid command). The change in this request would most probably have prevented such an error.