Skip to content

Completed VideoStoreAPI project #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sallyamoore wants to merge 104 commits into
base: lw+sm/master
Choose a base branch
from
Open

Completed VideoStoreAPI project #7

sallyamoore wants to merge 104 commits into from

Conversation

@sallyamoore
Copy link

@sallyamoore sallyamoore commented Sep 25, 2015

We completed all requirements. This was a great introduction to Node.js, albeit a complicated one. We also learned a lot more about SQL queries.

We have a couple of known bugs:

  • When you check in a movie, you check in all copies currently checked out by that customer. If a customer has more than one copy checked out, they must all be checked in simultneously.
    • Requirements said you can sort results from movies or customers by particular columns, but in our implementation, you can sort by any column.

We're both still figuring out the callback pattern... It will take more practice to get used to it.

All tests pass! Yay!

-Sally & Wang

sallyamoore and others added 30 commits September 15, 2015 16:39
@sallyamoore
Fresh node install.
9f2e721
@sallyamoore
Merge branch 'lw+sm/master' of github.com:sallyamoore/C3Projects--Vid…
e606316 
…eoStoreAPI into lw+sm/master
@sallyamoore
Added scaffolding notes so we both have access to them.
03673d6
@sallyamoore
Set up practice route and controller to return zomg.
ae08ed1
@sallyamoore
Added database.js, movies controller, and movies routes files.
fcb55f5
@sallyamoore
Added mocha for testing, wrote a coupel preliminary tests, wrote init…
eeec08d 
…ial query method for movies table.
@sallyamoore
Created schema and seed functionality for customers table, then seeded.
b4c36e9
@sallyamoore
moved seed files
2b7f39b
@wangg131
added number available to movie schema
aa9440c
@wangg131
added foreign keys to rental tables
eead190
@wangg131
Merge pull request #1 from sallyamoore/rental-setup
fea1b24 
added foreign keys to rental tables
@sallyamoore
Implemented a few more tests. WIP movies table initial tests.
bc2e17b
@wangg131
reorganized file structure and updated package.json
03adb91
@wangg131
WIP relationship between movies model and controller
64b73a3
@sallyamoore
First endpoint (to get all movies) is working. YAY.
d3e40d7
@sallyamoore
Set up schema in test.db and wrote test for /movies endpoint.
da3013e
@sallyamoore
Added endpoint to select column and return movie info for n movies of…
a0176d1 
…fset by p records.
@wangg131
created endpoints for all customers and subset of customers
9b57fe7
@wangg131
tests for customer
f4aad09
@wangg131
wip rental checkout
0168cea
@sallyamoore
WIP checkout functionality.
8a12d82
@sallyamoore
WIP post to rentals. Not working yet. Moving on to something else til…
8cf32b0 
…l we can get some help.
@sallyamoore
Merge pull request #2 from sallyamoore/sm-checkout
56f26e5 
Working on checkout functionality, but having trouble.
@sallyamoore
cleaning up a bit of the unfinished checkout stuff.
c94aa5f
@wangg131
not customers rentals.. got a list of customers that has checked out …
5675827 
…that movie's title
@sallyamoore
Merge pull request #3 from sallyamoore/customers_rentals
4f0f534 
not customers rentals.. got a list of customers that has checked out …
@sallyamoore
Added endpoint to checkout history for a given customer id.
dce88c8
@sallyamoore
fixed subset queries for movies and customers so all columns are retu…
be6c43e 
…rned and results are sorted by specified column.
@sallyamoore
Reformatted dates in rental seed file. Created endpoint for list of c…
4e73359 
…ustomers with overdue movies.
@wangg131
look up movie by title
8483a13
wangg131 and others added 30 commits September 23, 2015 17:33
@wangg131
dev db adding forgot
7729e50
@wangg131
added back updated_id to check_in
8008728
@sallyamoore
rental model tests, #check_out.
8ce7452
@sallyamoore
finished model tests for rentals.
c288b81
@sallyamoore
working on date formatting so that customers/overdue works correctly.
a14cf30
@sallyamoore
Formatting dates. Extracted function into helpers/date_helper.
15060dd
@wangg131
account credit cant go below zero
5189bd9
@sallyamoore
Merge pull request #15 from sallyamoore/sm-bugs
1101e57 
Formatted dates so that customers/overdue works correctly.
@wangg131
mergin
0b0cf51
@wangg131
Merge pull request #16 from sallyamoore/lw-bugs
ed5281b 
account credit cant go negative
@sallyamoore
updating rental functions to prevent execution of statements if one f…
60b4edf 
…ails.
@sallyamoore
Now only updating movie num_available and customer#account_credit if …
3f9f36f 
…checkout/checkin was successful.
@sallyamoore
Merge pull request #17 from sallyamoore/sm-inventory
4301e7e 
Fixed bugs - Now if one statement in checkout/checkin fails, others don't execute.
@wangg131
better rental controller tests
0be8098
@wangg131
rental controller tests
a86b7f5
@wangg131
deleted an unnecessary variable
405de1d
@wangg131
rental patch test
6461c37
@wangg131
test db
56356e2
@sallyamoore
Added constraints to inventory and num_available in movies. Cannot ch…
519e657 
…eck out unless available.
@wangg131
Merge pull request #18 from sallyamoore/rental-test
f4ee0c9 
Rental controller tests
@sallyamoore
fixing tests that failed b/c of changes to rentals model.
e6257e6
@sallyamoore
Cleaning up stray deprecated code.
1b44276
@sallyamoore
resolving merge conflicts
991e714
@sallyamoore
Merge pull request #19 from sallyamoore/sm-inventory-4real
be563d5 
Can only check out a movie if there's a copy of that movie available.
@wangg131
refactored model files into separate files
f0ab961
@wangg131
mergin refactor
7d754ed
@wangg131
Merge pull request #20 from sallyamoore/lw-refactor
72e5eff 
refactored model files into separate ones
@sallyamoore
Resetting the databases.
064a35d
@sallyamoore
Fixed little things that broke in our tests when we merged.
f5a456e
@sallyamoore
Adding back put route for rentals.
39c8eb7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sallyamoore @wangg131