Brenna and Corinne's excellent node adventure! #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e format of YYYYMMDD.
…ow calls the model function.
…stomer account credit and updating movie inventory_available
… updates the rental to have a check_in date and overdue is set to 0.
…ckin date and are overdue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Thank you so much for taking the time to review our code. We learned a lot during this project.
One thing we noticed but didn't have time to get to is that in the edge case of a customer checking out multiple copies of the same movie, upon check_in all copies would be checked in. A solution we though of would be to include the rental id in the request.
Thanks again,
Brenna + Corinne
P.S. Here is a handy dandy guide to our endpoint