-
Notifications
You must be signed in to change notification settings - Fork 20
Kja+vs/master #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ktrops
wants to merge
89
commits into
Ada-Developers-Academy:kja+vs/master
Choose a base branch
from
vikshab:kja+vs/master
base: kja+vs/master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Kja+vs/master #17
ktrops
wants to merge
89
commits into
Ada-Developers-Academy:kja+vs/master
from
vikshab:kja+vs/master
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created controllers folder Touched a file index.js Created a route for index
Wrote test for find_by function We have 3 green tests We added "test_schema": "DB=test node ./utils/schema.js" to package.json
Wrote a new function 'all_movies' in database.js Wrote test for 'all_movies' function, the test passed
Deleted index controller, created customers and movies controllers Created a route for endpoint '/movies' Find_all method works, I got it to display in json format on web page
Added new tests for customer model Added new routes for customer endpoints All 13 tests are green
… route for new endpoint
Added seed data for rentals
…le/available endpoint and added a new method availableMovies in movies contoller
Added route for checkin method Wrote SQlite queries for checkin endpoint
…ded callbacks) and I have a passing post test
….e. run_schema.js, run_seed.js)
…toreAPI into katie mering.
…est, added a new function in database - sort_by_registered_at
29 green tests, fixed movies_controller_test and custome_contollers_t…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.