Completed VideoStoreAPI Project -- Kml+adh/master #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… clean up later for final production.
…ing the db connection.
…e customersController.
WIP querying multiple times to movies db for customer renting and rented info
… the movie inventory_avail and customer account_credit. We are having to use test movie.title and customer.name now though because we haven't figured out how to execute that many queries at once. Working on that next.
…reAPI into kml+adh/master
…s name and movie's title before making the rental insert.
…nventory +1 and will update the rental record with a return_date of now.
…ts returned. Now called rental_history instead of just rental.
…reAPI into kml+adh/master
…o tell future users how to setup their test db before running our tests.
…hat it uses a different db when testing vs during development.
…ovie endpoint. We moved checking rentals into the rentals controller.
… finished writing tests for this endpoint.
…PI's generated result data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is our completed VideoStoreAPI project.
Please reference the 'endpoints.md' file to see documentation about all of our endpoints and the various query options that are available with each.
Edge cases we did not account for:
-Our 'checkout' function does not take into account whether a movie has available inventory or not. The movie inventory_avail number will go negative if you rent a movie with 0 units available.
Also, please read the note at the top of the README, which describes how to set up your local version of a test.db so that you can run our tests.
Thank you for your feedback!