Leaves - Hallie Johnson #14
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Apr 1, 2020
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Awesome work! You hit all the learning goals here. Well done.
Comment on lines
+2
to
7
| # Time Complexity: O(n); it iterates over each element in the nums array once. | ||
| # I don't think the max method adds meaningful time complexity. ? | ||
|
|
||
| # Space Complexity: O(1); makes the same number of variables regardless of nums size. | ||
| # Variables hold a single value and do not scale. | ||
| def max_sub_array(nums) |
Comment on lines
+3
to
5
| # Time complexity: O(n); processes scale based upon num input | ||
| # Space Complexity: O(n); space needs are in proportion to num input. | ||
| def newman_conway(num) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.